sjhajharia commented on code in PR #22786:
URL: https://github.com/apache/kafka/pull/22786#discussion_r3556313387
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##########
@@ -573,6 +612,19 @@ private static ArgumentParser argParser() {
.metavar("ACKNOWLEDGEMENT-MODE")
.help("Acknowledgement mode for the share consumers (must be
either 'auto', 'sync' or 'async')");
+ parser.addArgument("--ack-pattern")
Review Comment:
I think given its an internal class which we use only for our system tests
and do not expose it to customers, we shall be good to go ahead in this state.
Still, I am open to the other way round too if you think necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
