dajac commented on code in PR #22748:
URL: https://github.com/apache/kafka/pull/22748#discussion_r3551572984
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4358,6 +4421,14 @@ private UpdateTargetAssignmentResult<Map<String,
TasksTuple>> maybeUpdateStreams
return new UpdateTargetAssignmentResult<>(group.assignmentEpoch(),
updatedMembersAndTargetAssignment.targetAssignment());
}
+ if (refineOnly) {
Review Comment:
+1. It would good to be defensive here. I actually missed `group.state() ==
StreamsGroup.StreamsGroupState.STABLE` in the earlier condition and I thought
that this code was wrong.
It seems that we can also move this code up in the method. We don't need to
create updatedMembersAndTargetAssignment as it is not used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
