mjsax commented on code in PR #22748:
URL: https://github.com/apache/kafka/pull/22748#discussion_r3555739216
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4326,7 +4388,8 @@ private UpdateTargetAssignmentResult<Map<String,
TasksTuple>> maybeUpdateStreams
CoordinatorMetadataImage metadataImage,
List<CoordinatorRecord> records,
Optional<List<Status>> returnedStatus,
- Map<String, String> assignmentConfigs
+ Map<String, String> assignmentConfigs,
+ boolean refineOnly
Review Comment:
Well, `AssignmentUpdate` has three values, there is also `NONE`, which I
think should not get passed? So the question is, would `NONE` be an error case
and we throw, or would be tread `NONE` and `RECOMPUTE` the same way? In either
case, would it be cleaner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
