apoorvmittal10 commented on code in PR #22795:
URL: https://github.com/apache/kafka/pull/22795#discussion_r3558615782
##########
core/src/main/java/kafka/server/share/ReplicaManagerLogReader.java:
##########
@@ -162,6 +121,47 @@ public CompletableFuture<LinkedHashMap<TopicIdPartition,
LogReadResult>> readAsy
});
}
+ // Visible for testing
+ LinkedHashMap<TopicIdPartition, LogReadResult> read(
+ FetchParams fetchParams,
+ Set<TopicIdPartition> partitionsToFetch,
Review Comment:
The idea is to keep the API simple over set while caller can decide if wants
to use the LinkedHashSet vs other implementations i.e. if order matters or not.
Dor DelayedShareFetch order matters but not for ShareGroupDLQStateManager.
Please let me know if you disagree and we should change the behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
