chia7712 commented on code in PR #22795:
URL: https://github.com/apache/kafka/pull/22795#discussion_r3559413830
##########
core/src/main/java/kafka/server/share/ReplicaManagerLogReader.java:
##########
@@ -162,6 +121,47 @@ public CompletableFuture<LinkedHashMap<TopicIdPartition,
LogReadResult>> readAsy
});
}
+ // Visible for testing
+ LinkedHashMap<TopicIdPartition, LogReadResult> read(
+ FetchParams fetchParams,
+ Set<TopicIdPartition> partitionsToFetch,
Review Comment:
> can decide if wants to use the LinkedHashSet vs other implementations i.e.
if order matters or not.
the rationale behind this design is good to me. However, requiring
`LinkedHashMap` for `partitionMaxBytes` and `topicPartitionFetchOffsets` still
seems unnecessary. Since they are just used for lookups, the type Map should be
good enough in this method, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
