muralibasani commented on code in PR #22296:
URL: https://github.com/apache/kafka/pull/22296#discussion_r3560344388
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -1045,9 +1045,6 @@ private void handleShareAcknowledgeSuccess(Node
fetchTarget,
metadata.updatePartitionLeadership(partitionsWithUpdatedLeaderInfo,
leaderNodes);
}
- if (acknowledgeRequestState.isProcessed) {
Review Comment:
@apoorvmittal10 sorry for delayed reply.
And that's correct. With this change, latency is recorded only in
handleShareFetchSuccess, so a ShareAcknowledge-only round trip no longer
records latncy. I do not see any dedicated acknowledge-sensor now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
