muralibasani commented on code in PR #22296:
URL: https://github.com/apache/kafka/pull/22296#discussion_r3571921436
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -1045,9 +1045,6 @@ private void handleShareAcknowledgeSuccess(Node
fetchTarget,
metadata.updatePartitionLeadership(partitionsWithUpdatedLeaderInfo,
leaderNodes);
}
- if (acknowledgeRequestState.isProcessed) {
Review Comment:
@apoorvmittal10 a ShareAcknowledge request will not record latency, since
the only recordLatency call is in handleShareFetchSuccess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
