Jess668 commented on code in PR #22799:
URL: https://github.com/apache/kafka/pull/22799#discussion_r3571373295
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedWindowStoreWithHeaders.java:
##########
@@ -213,6 +224,47 @@ private <R> QueryResult<R> runWindowKeyQuery(
return queryResult;
}
+ /**
+ * Handles {@link TimestampedWindowKeyWithHeadersQuery} by forwarding a
raw byte-level
+ * {@link WindowKeyQuery} to the wrapped store and surfacing each entry as
a {@link ReadOnlyRecord}
+ * (via {@link Record}) whose key is a {@link Windowed} of the queried key
and the entry's window,
+ * carrying the stored value, event-time timestamp, and headers.
+ */
+ @SuppressWarnings("unchecked")
+ private <R> QueryResult<R> runTimestampedWindowKeyWithHeadersQuery(
+ final TimestampedWindowKeyWithHeadersQuery<K, V> query,
+ final PositionBound positionBound,
+ final QueryConfig config
+ ) {
+ final QueryResult<R> queryResult;
+
+ if (query.timeFrom().isPresent() && query.timeTo().isPresent()) {
Review Comment:
I kept it for parity and added a comment noting it's currently always-true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
