aliehsaeedii commented on code in PR #22799:
URL: https://github.com/apache/kafka/pull/22799#discussion_r3585539114
##########
streams/src/main/java/org/apache/kafka/streams/query/WindowKeyQuery.java:
##########
@@ -33,8 +33,8 @@ public class WindowKeyQuery<K, V> implements
Query<WindowStoreIterator<V>> {
private final Optional<Instant> timeTo;
private WindowKeyQuery(final K key,
- final Optional<Instant> timeTo,
- final Optional<Instant> timeFrom) {
+ final Optional<Instant> timeFrom,
+ final Optional<Instant> timeTo) {
Review Comment:
This reorder fixes a real bug (`getTimeFrom()`/`getTimeTo()` were
swapped)!!!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
