chia7712 commented on code in PR #20598:
URL: https://github.com/apache/kafka/pull/20598#discussion_r3574031213
##########
clients/src/main/java/org/apache/kafka/clients/admin/DescribeFeaturesResult.java:
##########
@@ -30,7 +30,13 @@ public class DescribeFeaturesResult {
private final KafkaFuture<FeatureMetadata> future;
- DescribeFeaturesResult(KafkaFuture<FeatureMetadata> future) {
+ /**
+ * This constructor is {@code protected} only to allow internal subclasses
(e.g.
+ * {@link
org.apache.kafka.clients.admin.internals.InternalDescribeFeaturesResult}) to
reuse it.
+ * It is not part of the public API contract, so binary/source
compatibility for subclassing
+ * outside of the Kafka clients module is not guaranteed.
+ */
+ protected DescribeFeaturesResult(KafkaFuture<FeatureMetadata> future) {
Review Comment:
This could be a kind of leak ... see
https://github.com/apache/kafka/pull/21337/files#r3574009798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
