chia7712 commented on code in PR #20598:
URL: https://github.com/apache/kafka/pull/20598#discussion_r3583549210
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -4548,12 +4550,17 @@ private static byte[] getSaltedPassword(ScramMechanism
publicScramMechanism, byt
@Override
public DescribeFeaturesResult describeFeatures(final
DescribeFeaturesOptions options) {
final KafkaFutureImpl<FeatureMetadata> future = new
KafkaFutureImpl<>();
+ final KafkaFutureImpl<NodeApiVersions> nodeApiVersionsFuture = new
KafkaFutureImpl<>();
final long now = time.milliseconds();
final NodeProvider nodeProvider = options.nodeId().isPresent() ?
new ConstantNodeIdProvider(options.nodeId().getAsInt(), true) :
new LeastLoadedBrokerOrActiveKController();
final Call call = new Call(
"describeFeatures", calcDeadlineMs(now, options.timeoutMs()),
nodeProvider) {
+ private NodeApiVersions createNodeApiVersion(final
ApiVersionsResponse response) {
+ return new NodeApiVersions(response.data().apiKeys(),
Collections.emptyList());
Review Comment:
Why don't we build a fully-featured `NodeApiVersions`?
```java
private NodeApiVersions createNodeApiVersion(final
ApiVersionsResponse response) {
return new NodeApiVersions(
response.data().apiKeys(),
response.data().supportedFeatures(),
response.data().finalizedFeatures(),
response.data().finalizedFeaturesEpoch());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
