dino2895 commented on PR #22809: URL: https://github.com/apache/kafka/pull/22809#issuecomment-4963595186
Thanks for the suggestion. I introduced `MeteredIteratorTracker` to keep the open-iterator counter and oldest-iterator tracking set encapsulated behind a single add/remove call. I migrated the relevant key-value store iterators, including `MeteredMultiVersionedKeyQueryIterator`, and fixed the same missing counter update in `MeteredTimestampedKeyValueStoreWithHeadersQueryIterator`. I also added regression tests for the with-headers `RangeQuery` and `TimestampedRangeQuery` paths, verifying the open-iterator metric transitions from 0 to 1 and back to 0. Verification: - `./gradlew :streams:spotlessJavaCheck` - `./gradlew :streams:checkstyleMain :streams:checkstyleTest` - `./gradlew :streams:test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
