lucliu1108 commented on code in PR #22807:
URL: https://github.com/apache/kafka/pull/22807#discussion_r3580304203
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamGlobalKTableJoin.java:
##########
@@ -17,22 +17,20 @@
package org.apache.kafka.streams.kstream.internals;
import org.apache.kafka.streams.kstream.KeyValueMapper;
-import org.apache.kafka.streams.kstream.ValueJoinerWithKey;
+import org.apache.kafka.streams.kstream.ValueJoinerWithMappedAndStreamKey;
import org.apache.kafka.streams.processor.api.Processor;
import org.apache.kafka.streams.processor.api.ProcessorSupplier;
-import java.util.Optional;
+class KStreamGlobalKTableJoin<StreamKey, StreamValue, TableKey, TableValue,
VOut> implements ProcessorSupplier<StreamKey, StreamValue, StreamKey, VOut> {
-class KStreamGlobalKTableJoin<K1, V1, K2, V2, VOut> implements
ProcessorSupplier<K1, V1, K1, VOut> {
-
- private final KTableValueGetterSupplier<K2, V2> valueGetterSupplier;
- private final ValueJoinerWithKey<? super K1, ? super V1, ? super V2, ?
extends VOut> joiner;
- private final KeyValueMapper<? super K1, ? super V1, ? extends K2> mapper;
+ private final KTableValueGetterSupplier<TableKey, TableValue>
valueGetterSupplier;
+ private final ValueJoinerWithMappedAndStreamKey<? super TableKey, ? super
StreamKey, ? super StreamValue, ? super TableValue, ? extends VOut> joiner;
Review Comment:
Thanks for the suggestion! Yeah these 2 options seems more logically correct
in terms of param order, i chose the second option, and since it calls
streamKey then mappedKey, i also renamed the interface to
`ValueJoinerWithStreamAndMappedKey`.
(The wiki page is very slow yesterday and today on my side, will update it
later and send an email to the vote thread).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
