lucliu1108 commented on code in PR #22807: URL: https://github.com/apache/kafka/pull/22807#discussion_r3580329634
########## streams/src/main/java/org/apache/kafka/streams/kstream/ValueJoinerWithMappedAndStreamKey.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.kstream; + +/** + * The {@code ValueJoinerWithMappedAndStreamKey} interface for joining two values into a new value of + * arbitrary type, with access to both the mapped join key and the original {@link KStream} record key. + * Used by {@link KStream}-{@link GlobalKTable} joins, where the join key is produced by a + * {@link KeyValueMapper} and does not necessarily equal the {@link KStream} record's key. + * + * @param <K1> the type of the mapped join key (the {@link GlobalKTable} lookup key) + * @param <K2> the type of the original {@link KStream} record key + * @param <V1> the type of the first (stream) value + * @param <V2> the type of the second (table) value + * @param <VR> the type of the joined result value + */ +@FunctionalInterface +public interface ValueJoinerWithMappedAndStreamKey<K1, K2, V1, V2, VR> { Review Comment: Fix: Use `ValueJoinerWithStreamAndMappedKey<StreamKey, TableKey, StreamValue, TableValue, VOut>` now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
