josefk31 commented on code in PR #22669: URL: https://github.com/apache/kafka/pull/22669#discussion_r3581962311
########## raft/src/testFixtures/java/org/apache/kafka/raft/DrainableCounter.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.raft; + +import java.util.function.IntSupplier; + +/** + * Tracks a cumulative, monotonically increasing counter (e.g. the work counters on the raft mocks) as + * a drainable delta against a baseline. The baseline is snapshotted at construction, and + * {@link #drainDelta()} returns the increase since construction or the previous drain, consuming it so + * nothing is counted twice. Draining with the result ignored therefore re-baselines the counter, e.g. + * to exclude setup work from the next measurement. + */ +final class DrainableCounter { + private final IntSupplier source; + private int baseline; Review Comment: See other comment about `drainDelta` returning an `int` ########## raft/src/testFixtures/java/org/apache/kafka/raft/DrainableCounter.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.raft; + +import java.util.function.IntSupplier; + +/** + * Tracks a cumulative, monotonically increasing counter (e.g. the work counters on the raft mocks) as + * a drainable delta against a baseline. The baseline is snapshotted at construction, and + * {@link #drainDelta()} returns the increase since construction or the previous drain, consuming it so + * nothing is counted twice. Draining with the result ignored therefore re-baselines the counter, e.g. + * to exclude setup work from the next measurement. + */ +final class DrainableCounter { + private final IntSupplier source; + private int baseline; + + DrainableCounter(IntSupplier source) { + this.source = source; + this.baseline = source.getAsInt(); + } + + int drainDelta() { Review Comment: Why are we returning an `int` for this value? I notice that we have a test to check whether this overflows. If we anticipate that there will be at least one overflow, it makes sense to anticipate that there might be multiple overflows. I'm not sure if the implementation is correct if an overflow happens twice before `counter.drainDelta` is called. If overflows are expected when we're running this counter, then does it makes more sense to return a `long`? In fact, it seems like the counters in `KRaftBenchmarkingCounters` are all `long`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
