suzhiking commented on code in PR #22586:
URL: https://github.com/apache/kafka/pull/22586#discussion_r3752690018
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1375,37 +1367,42 @@ public class StreamsConfig extends AbstractConfig {
TOPOLOGY_DESCRIPTION_PUSH_ENABLED_DOC);
}
- // this is the list of configs for underlying clients
- // that streams prefer different default values
- private static final Map<String, Object> PRODUCER_DEFAULT_OVERRIDES =
Map.of(ProducerConfig.LINGER_MS_CONFIG, "100");
+ // Configs for the underlying clients that Streams prefers different
default values for.
+ // These are only defaults: the user may still override them.
+ private static final Map<String, Object> DEFAULT_CONSUMER_CONFIGS = Map.of(
+ ConsumerConfig.MAX_POLL_RECORDS_CONFIG, DEFAULT_MAX_POLL_RECORDS,
Review Comment:
good point, I changed all of them to in-place constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
