suzhiking commented on PR #22586: URL: https://github.com/apache/kafka/pull/22586#issuecomment-5245155310
@Nikita-Shupletsov I've pushed changes that addressed the comments. To answer claude's review: 1. `getMainConsumerConfigs` now forces `group.id` to `application.id` in instead of `groupId` parameter which might be dummy for internal functions that only read unrelated value. 2. `max.in.flight.requests.per.connection` is a producer config so now it's only validated there, documented in PR body. 3. Added tests for this fix 4. Added `reason` parameter to `overwriteControlledConfig` that appends reason to end of `CONTROLLED_CONFIG_OVERRIDE_MESSAGE`. 5. Applied the fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
