chia7712 commented on code in PR #23185:
URL: https://github.com/apache/kafka/pull/23185#discussion_r3803765164


##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -1929,7 +1930,7 @@ private FetchSnapshotResponseData 
handleFetchSnapshotRequest(
             return new 
FetchSnapshotResponseData().setErrorCode(Errors.INCONSISTENT_CLUSTER_ID.code());
         }
 
-        if (data.topics().size() != 1 && 
data.topics().get(0).partitions().size() != 1) {
+        if (data.topics().size() != 1 || 
data.topics().get(0).partitions().size() != 1) {

Review Comment:
   I assume you will implement a helper method in `RaftUtil` to handle this 
check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to