kevin-wu24 commented on code in PR #23185:
URL: https://github.com/apache/kafka/pull/23185#discussion_r3817122864
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##########
@@ -767,6 +767,51 @@ public void
testFetchSnapshotRequestUnknownPartition(boolean withKip853Rpc) thro
assertEquals(Errors.UNKNOWN_TOPIC_OR_PARTITION,
Errors.forCode(response.errorCode()));
}
+ @ParameterizedTest
+ @ValueSource(booleans = { false, true })
+ public void testFetchSnapshotRequestWithoutTopics(boolean withKip853Rpc)
throws Exception {
+ int localId = randomReplicaId();
+ Set<Integer> voters = Set.of(localId, localId + 1);
+
+ RaftClientTestContext context = new
RaftClientTestContext.Builder(localId, voters)
+ .withUnknownLeader(3)
+ .withKip853Rpc(withKip853Rpc)
Review Comment:
Fixed, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
