mjsax commented on code in PR #23276:
URL: https://github.com/apache/kafka/pull/23276#discussion_r3882114731
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -514,8 +514,9 @@ private static void
validateNoDuplicateRackAwareAssignmentTags(Map<String, Strin
if (rawValue == null) {
return;
}
- String trimmed = rawValue.trim();
- List<String> rawTags = trimmed.isEmpty() ? List.of() :
List.of(trimmed.split("\\s*,\\s*", -1));
+ @SuppressWarnings("unchecked")
+ List<String> rawTags = (List<String>) ConfigDef.parseType(
+ STREAMS_RACK_AWARE_ASSIGNMENT_TAGS_CONFIG, rawValue,
ConfigDef.Type.LIST);
Review Comment:
Make it either one line, or if too long, one parameter per line. That's
easier to read for the human eye, and also reduced git-diff size is code is
changes later.
Also avoid 8-space indention -- might be an IntelliJ setting (or instruct
Claude) with proper formatting rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
