mjsax commented on code in PR #23276:
URL: https://github.com/apache/kafka/pull/23276#discussion_r3882130150
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -798,12 +798,14 @@ private void verifyStreamsGroupConfigs() {
* Returns the rack-aware assignment tags exactly as configured, before
{@link ConfigDef} removes duplicates.
*/
private List<String> rawRackAwareAssignmentTags() {
- String rawValue = (String)
config.originals().get(STREAMS_GROUP_RACK_AWARE_ASSIGNMENT_TAGS_CONFIG);
+ Object rawValue =
config.originals().get(STREAMS_GROUP_RACK_AWARE_ASSIGNMENT_TAGS_CONFIG);
if (rawValue == null) {
return List.of();
}
- String trimmed = rawValue.trim();
- return trimmed.isEmpty() ? List.of() :
List.of(trimmed.split("\\s*,\\s*", -1));
+ @SuppressWarnings("unchecked")
+ List<String> rawTags = (List<String>) ConfigDef.parseType(
+ STREAMS_GROUP_RACK_AWARE_ASSIGNMENT_TAGS_CONFIG, rawValue,
ConfigDef.Type.LIST);
Review Comment:
formatting. as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
