mimaison commented on code in PR #23316:
URL: https://github.com/apache/kafka/pull/23316#discussion_r3903196461
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##########
@@ -294,8 +288,9 @@ public int sizeInBytes() {
}
public void close() throws IOException {
- flush(); // Ensure the index content is flushed to disk as
LogSegment.close may append an entry
- trimToValidSize(true);
+ flush(false); // Ensure the index content is flushed to disk as
LogSegment.close may append an entry
Review Comment:
Yes that's the reason I kept the two `flush()` calls. I did not want risking
changing the behavior, and potentially breaking other things. It seems flushing
an already flushed file is relatively cheap.
If both of you agree a single `flush(true)` after `trimToValidSize()` is
fine, I'm happy to make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
