junrao commented on code in PR #23316:
URL: https://github.com/apache/kafka/pull/23316#discussion_r3915763985
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##########
@@ -253,11 +242,17 @@ public void renameTo(File f) throws IOException {
/**
* Flush the data in the index to disk
+ * @param metadata true if the metadata should be flushed as well
*/
- public void flush() {
+ public void flush(boolean metadata) throws IOException {
Review Comment:
All callers now set metadata to true. Could we remove metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
