frankvicky commented on code in PR #23364:
URL: https://github.com/apache/kafka/pull/23364#discussion_r3952652453
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1926,6 +1939,7 @@ public Map<String, Object> getMainConsumerConfigs(final
String groupId, final St
final Map<String, Object> mainConsumerProps =
originalsWithPrefix(MAIN_CONSUMER_PREFIX);
checkIfUnexpectedUserSpecifiedClientConfig(mainConsumerProps,
NON_CONFIGURABLE_CONSUMER_DEFAULT_CONFIGS);
consumerProps.putAll(mainConsumerProps);
+ enforceSynchronousBootstrapResolution(consumerProps, "consumer");
Review Comment:
Just take a look at `checkIfUnexpectedUserSpecifiedClientConfig`. It seems
that it has no producer or admin path. `getProducerConfigs` only calls it with
`NON_CONFIGURABLE_PRODUCER_EOS_CONFIGS`, and `getAdminConfigs` never calls it.
Inside the method, the only non EOS branch is the one keyed on
`CONSUMER_DEFAULT_OVERRIDES` and it hard-codes "consumer" in the log message,
so reusing it for the producer or admin would need a new branch. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
