chia7712 commented on code in PR #23364:
URL: https://github.com/apache/kafka/pull/23364#discussion_r3976326919
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -624,7 +625,15 @@ public String groupId() {
protected Map<String, Object> postProcessParsedConfig(final Map<String,
Object> parsedValues) {
CommonClientConfigs.warnDisablingExponentialBackoff(this);
warnIfConnectionsMaxIdleMsLowerThanRebalanceTimeoutMs();
- return super.postProcessParsedConfig(parsedValues);
+ Map<String, Object> configUpdates = new
HashMap<>(super.postProcessParsedConfig(parsedValues));
Review Comment:
Rethinking this ... we should add a warning for `group.protocol=CONSUMER`
instead. We already opened the door for Connect users to set
`group.protocol=CONSUMER`, so locking it down would be a behavior change. We
could remind users that Connect with group.protocol=CONSUMER is not fully
tested for production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
