alanlau28 commented on code in PR #23317:
URL: https://github.com/apache/kafka/pull/23317#discussion_r3962733943
##########
generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java:
##########
@@ -141,6 +152,7 @@ public void generateAndWrite(BufferedWriter writer) throws
IOException {
}
private void generate() {
+ validateHeaderVersions();
Review Comment:
Moved to `MessageSpec` as `checkApiVersionsResponseHeaderVersion()`. I used
a hardcoded constant to check api version for this, but curious to know wdyt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
