chia7712 commented on code in PR #23317:
URL: https://github.com/apache/kafka/pull/23317#discussion_r3990106485
##########
generator/src/test/java/org/apache/kafka/message/HeaderVersionsTest.java:
##########
@@ -245,10 +279,25 @@ public void
testFlexibleRequestVersionNeedsFlexibleHeader() {
}
@Test
- public void testFlexibleRequestAcceptsNewerHeaderVersion() throws
Exception {
- // Request header v3 (KIP-1313) is flexible, so a flexible body may
declare it.
- MessageSpec spec = parse(requestSpec("0-5", "0+", "{'0+': '3'}"));
- assertEquals((short) 3,
spec.headerVersions().orElseThrow().entries().get(0).headerVersion());
+ public void testRequestHeaderVersionMustExist() {
+ // Request header v3 does not exist yet, so a schema may not declare
it.
Review Comment:
Should we add a "Header Versions" section to
`clients/src/main/resources/common/message/README.md` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
