lucasbru commented on code in PR #23004:
URL: https://github.com/apache/kafka/pull/23004#discussion_r3965716585
##########
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##########
@@ -497,12 +498,21 @@ private void replaceStreamThread(final Throwable
throwable) {
" The streams client is going to shut down now. ",
throwable);
closeToError();
}
+
final StreamThread deadThread = (StreamThread) Thread.currentThread();
Review Comment:
Not caused by this PR, but since we're restructuring this function: if the
uncaught exception came from GlobalStreamThread (which extends Thread directly,
not StreamThread) and hits this name-match branch, closeToError() is called but
there's no return, so we fall through to `(StreamThread)
Thread.currentThread()` on the next line, which throws ClassCastException
instead of cleanly shutting down. Worth a quick fix here, or a follow-up ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
