lucasbru commented on code in PR #23004: URL: https://github.com/apache/kafka/pull/23004#discussion_r3977296403
########## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ########## @@ -44,6 +44,7 @@ import org.apache.kafka.common.utils.Timer; import org.apache.kafka.common.utils.Utils; import org.apache.kafka.common.utils.internals.LogContext; +import org.apache.kafka.streams.CloseOptions.GroupMembershipOperation; Review Comment: Nit: this new import gives `GroupMembershipOperation` the short form at a few call sites in this method, but the rest of the file (close(), etc.) still uses the fully-qualified `org.apache.kafka.streams.CloseOptions.GroupMembershipOperation`. Worth a follow-up to normalize, or intentional to keep the diff small? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
