[ 
https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022400#comment-17022400
 ] 

Matthias J. Sax commented on KAFKA-9471:
----------------------------------------

Considering KIP-216, I think we need to make sure we throw an exception if 
`KafkaStream` state is DEAD or PENDING_SHUTDOWN or ERROR.

This ticket is about `StreamThread` state though. Not sure why we return an 
emptyList for state DEAD but throw an exception for all others states (except 
RUNNING). \cc [~vitojeng] who works on KIP-216.

> Return empty collection for PENDING_SHUTDOWN
> --------------------------------------------
>
>                 Key: KAFKA-9471
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9471
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>
> In StreamThreadStateStoreProvider we have:
> {code}
> if (streamThread.state() == StreamThread.State.DEAD) {
>     return Collections.emptyList();
> {code}
> PENDING_SHUTDOWN is precursor to DEAD state.
> PENDING_SHUTDOWN should be treated the same way as DEAD.
> This makes more sense than current behavior of throwing exception for 
> PENDING_SHUTDOWN.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to