[ https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022586#comment-17022586 ]
Vito Jeng commented on KAFKA-9471: ---------------------------------- Thanks [~yuzhih...@gmail.com] point this. In KIP-216, we handle state store related exception based on Streams state, not StreamThread state. IMHO, I think we should throw exception rather than empty list and user cannot retry anymore. > Return empty collection for PENDING_SHUTDOWN > -------------------------------------------- > > Key: KAFKA-9471 > URL: https://issues.apache.org/jira/browse/KAFKA-9471 > Project: Kafka > Issue Type: Improvement > Components: streams > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Minor > > In StreamThreadStateStoreProvider we have: > {code} > if (streamThread.state() == StreamThread.State.DEAD) { > return Collections.emptyList(); > {code} > PENDING_SHUTDOWN is precursor to DEAD state. > PENDING_SHUTDOWN should be treated the same way as DEAD. > This makes more sense than current behavior of throwing exception for > PENDING_SHUTDOWN. -- This message was sent by Atlassian Jira (v8.3.4#803005)