cmccabe commented on a change in pull request #8610: URL: https://github.com/apache/kafka/pull/8610#discussion_r419793865
########## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ########## @@ -329,11 +329,13 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo def getEntityConfigs(rootEntityType: String, sanitizedEntityName: String): Properties = { val getDataRequest = GetDataRequest(ConfigEntityZNode.path(rootEntityType, sanitizedEntityName)) val getDataResponse = retryRequestUntilConnected(getDataRequest) - + warn(s"rootEntityType = $rootEntityType sanitizedEntityName = $sanitizedEntityName") getDataResponse.resultCode match { case Code.OK => ConfigEntityZNode.decode(getDataResponse.data) - case Code.NONODE => new Properties() + case Code.NONODE => + warn(s"Code.NONODE reached, creating empty properties") Review comment: should be removed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org