d8tltanc commented on pull request #8610:
URL: https://github.com/apache/kafka/pull/8610#issuecomment-624308593


   Hi @bdbyrne , thanks for the comment. The link seems not working. I guess 
you mean this part we should replace the empty string "" by null?
   `    private[admin] def entityNames(): List[String] = {
         val namesIterator = options.valuesOf(entityName).iterator
         options.specs.asScala
           .filter(spec => spec.options.contains("entity-name") || 
spec.options.contains("entity-default"))
           .map(spec => if (spec.options.contains("entity-name")) 
namesIterator.next else "").toList ++
         entityFlags
           .filter(entity => options.has(entity._1))
           .map(entity => options.valueOf(entity._1)) ++
         entityDefaultsFlags
           .filter(entity => options.has(entity._1))
           .map(_ => "")
       }`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to