gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420998369
########## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ########## @@ -856,6 +858,47 @@ public void run() { PowerMock.verifyAll(); } + @Test + public void testSinkTasksHandleCloseErrors() throws Exception { Review comment: Ive written the test as-is, and the exception from close is caught by WorkerTask::doRun. However, it never gets wrapped in a ConnectException like exceptions from the other connector methods, but i'm not sure that it's in-scope to change this in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org