gharris1727 commented on a change in pull request #8618:
URL: https://github.com/apache/kafka/pull/8618#discussion_r421009491
##########
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java
##########
@@ -856,6 +858,47 @@ public void run() {
PowerMock.verifyAll();
}
+ @Test
+ public void testSinkTasksHandleCloseErrors() throws Exception {
Review comment:
I added that test, so please look at the diff.
By wrapping, i'm completely disregarding the behavior from the connector,
I'm only discussing the additional layers of exceptions added by the framework
before printing.
At the moment, the RuntimeException from put is wrapped by a
ConnectException, but the RuntimeException from close is never wrapped in a
ConnectException. I'm questioning whether this is the ideal behavior, and
whether we should add that wrapping layer, or consider it out-of-scope for this
PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
