badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r431621469
##########
File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java
##########
@@ -22,7 +22,8 @@
DEFAULT("default"),
USE_ALL_DNS_IPS("use_all_dns_ips"),
-
RESOLVE_CANONICAL_BOOTSTRAP_SERVERS_ONLY("resolve_canonical_bootstrap_servers_only");
+
RESOLVE_CANONICAL_BOOTSTRAP_SERVERS_ONLY("resolve_canonical_bootstrap_servers_only"),
+ USE_FIRST_DNS_IP("use_first_dns_ip");
Review comment:
I think that is a better idea, instead of introducing new value that
would be removed soon.
`ClientDnsLookup.DEFAULT` is used in few places in core (server):
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaServer.scala#L520
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ReplicaFetcherBlockingSend.scala#L92
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/controller/ControllerChannelManager.scala#L156
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala#L82
And a couple of tools:
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala#L482
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala#L299
It is also used literally in a lot of test cases under clients.
I did not want to touch too many code in the first go. Should I change them
all in this KIP or leave them until we remove `ClientDnsLookup.DEFAULT` in 3.0 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
