[GitHub] [kafka] badaiaqrandista commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

[GitBox]

badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r432768002



##########
File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java
##########
@@ -22,7 +22,8 @@
 
     DEFAULT("default"),
     USE_ALL_DNS_IPS("use_all_dns_ips"),
-    
RESOLVE_CANONICAL_BOOTSTRAP_SERVERS_ONLY("resolve_canonical_bootstrap_servers_only");
+    
RESOLVE_CANONICAL_BOOTSTRAP_SERVERS_ONLY("resolve_canonical_bootstrap_servers_only"),
+    USE_FIRST_DNS_IPS("use_first_dns_ips");

Review comment:
       @mimaison Based on @ijuma 's suggestion, I am not adding 
`use_first_dns_ip`. I am going to deprecate `default` as the value and make 
`use_all_dns_ips` as the default value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org