ableegoldman commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r431974679
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/TaskAssignorIntegrationTest.java
##########
@@ -89,7 +89,7 @@ public void shouldProperlyConfigureTheAssignor() throws
NoSuchFieldException, Il
mkEntry(StreamsConfig.MAX_WARMUP_REPLICAS_CONFIG, "7"),
mkEntry(StreamsConfig.PROBING_REBALANCE_INTERVAL_MS_CONFIG,
"480000"),
mkEntry(StreamsConfig.InternalConfig.ASSIGNMENT_LISTENER,
configuredAssignmentListener),
- mkEntry(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG, 9)
+ mkEntry(AdminClientConfig.DEFAULT_API_TIMEOUT_MS_CONFIG,
90_000)
Review comment:
For fun
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/TaskAssignorIntegrationTest.java
##########
@@ -89,7 +89,7 @@ public void shouldProperlyConfigureTheAssignor() throws
NoSuchFieldException, Il
mkEntry(StreamsConfig.MAX_WARMUP_REPLICAS_CONFIG, "7"),
mkEntry(StreamsConfig.PROBING_REBALANCE_INTERVAL_MS_CONFIG,
"480000"),
mkEntry(StreamsConfig.InternalConfig.ASSIGNMENT_LISTENER,
configuredAssignmentListener),
- mkEntry(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG, 9)
+ mkEntry(AdminClientConfig.DEFAULT_API_TIMEOUT_MS_CONFIG,
90_000)
Review comment:
I mean, because the value has to be larger than the `request.timeout.ms`
which defaults to 30,000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
