[GitHub] [kafka] ableegoldman commented on a change in pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

[GitBox]

ableegoldman commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r431984937



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java
##########
@@ -90,24 +96,21 @@ public static String getTaskProducerClientId(final String 
threadClientId, final
         return result;
     }
 
-    public static Map<TopicPartition, ListOffsetsResultInfo> 
fetchEndOffsetsWithoutTimeout(final Collection<TopicPartition> partitions,
-                                                                               
            final Admin adminClient) {
-        return fetchEndOffsets(partitions, adminClient, null);
+    public static int getAdminDefaultApiTimeoutMs(final StreamsConfig 
streamsConfig) {
+        final InternalAdminClientConfig dummyAdmin = new 
InternalAdminClientConfig(streamsConfig.getAdminConfigs("dummy"));

Review comment:
       Ack




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org