dajac commented on pull request #8808: URL: https://github.com/apache/kafka/pull/8808#issuecomment-644192842
@tombentley I am not sure to follow what the `AppInfoParser` is doing here... Could you elaborate a bit more? Regarding option 2), I had a quick look at the implementation and it seems that it verifies that no errors are printed out but it does not really verify that the output is correct. For instance, if we would remove the `listAcls(adminClient)` at L115, we would not catch it, isn't it? Perhaps, we could add a small test for the `listAcls()` method which adds few ACLs, graps the output with `TestUtils.grabConsoleOutput` and verifies it. I think that it is probably enough given the scope of the change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
