mjsax commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r443871712
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
##########
@@ -267,7 +283,17 @@ public void close() {
private void checkForException() {
if (sendException != null) {
- throw sendException;
+ if (sendException.getCause() instanceof KafkaException
+ && sendException.getCause().getMessage().equals("Failing batch
since transaction was aborted")) {
Review comment:
> I think, that we should never hit this exception during closeClean,
that is, we should never call closeClean on a task/record collector that was
part of an aborted transaction.
Agreed.
I was hoping we don't need this hack at all? Why do we want to call
`checkForException` in close dirty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
