ableegoldman commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r443950646
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java
##########
@@ -359,7 +359,9 @@ public void
shouldRecycleStateFromStandbyTaskPromotedToActiveTaskAndNotRestore()
waitForStandbyCompletion(client1, 1, 30 * 1000L);
waitForStandbyCompletion(client2, 1, 30 * 1000L);
- assertThat(CloseCountingInMemoryStore.numStoresClosed(),
CoreMatchers.equalTo(0));
+ // Sometimes the store happens to have already been closed sometime
during startup, so just keep track
+ // of where it started and make sure it doesn't happen more times from
there
+ final int initialStoreCloseCount =
CloseCountingInMemoryStore.numStoresClosed();
Review comment:
Saw this fail locally so just did a minor flaky test fix on the side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
