ableegoldman commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r444528622



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java
##########
@@ -474,6 +492,7 @@ public void 
shouldThrowTaskMigratedExceptionOnSubsequentCallWhenProducerFencedIn
                 " indicating the task may be migrated out; it means all tasks 
belonging to this thread should be migrated.")
         );
 
+        collector.send(topic, "3", "0", null, null, stringSerializer, 
stringSerializer, streamPartitioner);

Review comment:
       Maybe I misinterpreted this, but I took the `OnSubsequentCall` in the 
name to mean that it would throw on the next (ie subsequent) call after the 
_send_, not that it would continue to throw on all subsequent calls. ie I think 
it should actually be several different tests (one for each "call" that should 
throw) but got mashed into just one




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to