mjsax commented on a change in pull request #8900:
URL: https://github.com/apache/kafka/pull/8900#discussion_r444538711



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java
##########
@@ -474,6 +492,7 @@ public void 
shouldThrowTaskMigratedExceptionOnSubsequentCallWhenProducerFencedIn
                 " indicating the task may be migrated out; it means all tasks 
belonging to this thread should be migrated.")
         );
 
+        collector.send(topic, "3", "0", null, null, stringSerializer, 
stringSerializer, streamPartitioner);

Review comment:
       Not 100% sure how `OnSubsequentCall` is meant either. But what you say 
seems to make sense and thus it should be different test. Thanks for the extra 
mile splitting them up!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to