kkonstantine commented on a change in pull request #8928:
URL: https://github.com/apache/kafka/pull/8928#discussion_r450292688



##########
File path: 
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
##########
@@ -76,6 +78,15 @@ public void setup() {
 
         // start the clusters
         connect.start();
+
+        // wait for the Connect REST API to become available. necessary 
because of the reduced REST
+        // request timeout; otherwise, we may get an unexpected 500 with our 
first real REST request
+        // if the worker is still getting on its feet.
+        waitForCondition(

Review comment:
       Should we just hit the endpoint that lists connectors to verify that the 
worker is ready to serve REST requests? 
   
   That's what we've been doing in system tests: 
   
https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/connect.py#L110
   
   Given that this is a valid endpoint and doesn't need an artificial connector 
name seems less hacky and we could include this condition overall in the utils. 
Wdyt?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to