kkonstantine commented on a change in pull request #8928:
URL: https://github.com/apache/kafka/pull/8928#discussion_r451832657



##########
File path: 
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
##########
@@ -76,6 +78,15 @@ public void setup() {
 
         // start the clusters
         connect.start();
+
+        // wait for the Connect REST API to become available. necessary 
because of the reduced REST
+        // request timeout; otherwise, we may get an unexpected 500 with our 
first real REST request
+        // if the worker is still getting on its feet.
+        waitForCondition(

Review comment:
       Interesting observation. Of course, hitting the leader with a request 
doesn't tell you that other workers have started, so that's applicable in tests 
like this one, which start only one worker here, etc. This doesn't seem to be a 
race condition we encounter often, so I'm fine with an ad hoc specific fix here 
given the reduced timeout. I'd be surprised if it took noticeable time to load 
the services after the herder is submitted to its executor. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to