cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r452119998
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ########## @@ -45,24 +45,23 @@ protected ProcessorNode<?, ?> currentNode; private long currentSystemTimeMs; - final StateManager stateManager; Review comment: This is basically to avoid the cast from `StateManager` to `ProcessorStateManager` in `ProcessorContextImpl`. `ProcessorStateManager` has method `registeredChangelogPartitionFor()` that does only exist in the `ProessorStateManager`, because it is only used in `ProcessorContextImpl`. Hence, I moved the state manager field to the respective children and introduced the abstract method `stateManager()` in `AbstractProcessorContext`. Method `stateManager()` returns a `ProcessorStateManager` in `ProcessorContextImpl` but a `StateManager` in all other places. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org