cadonna commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r452425472
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java
##########
@@ -45,24 +45,23 @@
protected ProcessorNode<?, ?> currentNode;
private long currentSystemTimeMs;
- final StateManager stateManager;
Review comment:
If I understand you correctly, you propose to have a processor state
manager reference in the `AbstractProcessorContext` and in
`ProcessorContextImpl` instead of in the `GlobalProcessorContextImpl` and in
`ProcessorContextImpl`. Moreover, you want to have a method `stateManager()` in
`AbstractProcessorContext` that is overridden only in `ProcessorContextImpl`.
FWIW, I think it is cleaner to have the references in each child and an
abstract method `stateManager()` in `AbstractProcessorContext` that is
overridden in both children. My reasoning is that both children have a state
manager that is used in `AbstractProcessorContext` (i.e., both should provide a
method `stateManager()`) but each child uses a different type of state manager
internally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
