mjsax commented on a change in pull request #8994:
URL: https://github.com/apache/kafka/pull/8994#discussion_r452620905



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -768,9 +770,30 @@ void runOnce() {
 
     private void resetInvalidOffsets(final InvalidOffsetException e) {
         final Set<TopicPartition> partitions = e.partitions();
+        final Set<TopicPartition> notReset = resetOffsets(partitions);
+        if (!notReset.isEmpty()) {
+            final String notResetString =
+                notReset.stream()
+                        .map(tp -> "topic " + tp.topic() + "(partition " + 
tp.partition() + ")")
+                        .collect(Collectors.joining(","));

Review comment:
       Nit: As reset policy is set on a per topic basis, it's sufficient to 
list the topic names -- it does not add value if we list the partitions, 
because all assigned partitions would be affected anyway.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to