mjsax commented on a change in pull request #8994:
URL: https://github.com/apache/kafka/pull/8994#discussion_r452939323
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -768,9 +770,30 @@ void runOnce() {
private void resetInvalidOffsets(final InvalidOffsetException e) {
final Set<TopicPartition> partitions = e.partitions();
+ final Set<TopicPartition> notReset = resetOffsets(partitions);
+ if (!notReset.isEmpty()) {
+ final String notResetString =
+ notReset.stream()
+ .map(tp -> "topic " + tp.topic() + "(partition " +
tp.partition() + ")")
+ .collect(Collectors.joining(","));
Review comment:
I think it would be good. Seems the original message should not have
contained the partition to begin with. Even if for the original one, it's less
severe because we only consider a single topic-partition in the error message.
For this new case, we get multiple topic-partitions and the error message
might become quite large? Also, if multiple task of the same sub-topology are
assigned, the same topic name might appear multiple times for different
partitions? Might be best to only add a `Set` or topic names to the error
message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
